controlsManager: Don't fade icon grid while dragging

As pointed out by designers, fading it signals that the
icon grid is not a drop target, when now it actually is.

Remove the fade effect applied to the icon grid when
dragging. Since this is the only caller of fadeIn() and
fadeHalf(), also remove these methods.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/664

diff --git a/js/ui/overviewControls.js b/js/ui/overviewControls.js
index c9f9872c8eb60c5f5e2a94ee6a7443649aacdfb0..cf24a5e566103fbf06fac3fd3178372554a7784e 100644 (file)
--- a/js/ui/overviewControls.js
+++ b/js/ui/overviewControls.js
@@ -447,17 +447,6 @@ var ControlsManager = class {
         layout.connect('allocation-changed', this._updateWorkspacesGeometry.bind(this));
 
         Main.overview.connect('showing', this._updateSpacerVisibility.bind(this));
-        Main.overview.connect('item-drag-begin', () => {
-            let activePage = this.viewSelector.getActivePage();
-            if (activePage != ViewSelector.ViewPage.WINDOWS)
-                this.viewSelector.fadeHalf();
-        });
-        Main.overview.connect('item-drag-end', () => {
-            this.viewSelector.fadeIn();
-        });
-        Main.overview.connect('item-drag-cancelled', () => {
-            this.viewSelector.fadeIn();
-        });
     }
 
     _updateWorkspacesGeometry() {

diff --git a/js/ui/viewSelector.js b/js/ui/viewSelector.js
index 9aef3b9ddbd386b021409c312278ba221e69c879..c4201239e80a0e2ebb0ec51f4565d182aa2c2ae3 100644 (file)
--- a/js/ui/viewSelector.js
+++ b/js/ui/viewSelector.js
@@ -599,23 +599,5 @@ var ViewSelector = class {
         else
             return ViewPage.SEARCH;
     }
-
-    fadeIn() {
-        let actor = this._activePage;
-        actor.ease({
-            opacity: 255,
-            duration: OverviewControls.SIDE_CONTROLS_ANIMATION_TIME / 2,
-            mode: Clutter.AnimationMode.EASE_IN_QUAD
-        });
-    }
-
-    fadeHalf() {
-        let actor = this._activePage;
-        actor.ease({
-            opacity: 128,
-            duration: OverviewControls.SIDE_CONTROLS_ANIMATION_TIME / 2,
-            mode: Clutter.AnimationMode.EASE_OUT_QUAD
-        });
-    }
 };
 Signals.addSignalMethods(ViewSelector.prototype);